On Tue, Jul 10, 2018 at 10:52:22AM +0200, Henning Schild wrote: > This series adds support for signing commits with gpgsm. Thanks for working on this. I left a bunch of comments, but overall the direction looks good. We talked about this a bit off-list, but just for the public record: > This series can be seen as a follow up of a series that appeared under > the name "gpg-interface: Multiple signing tools" in april 2018 [1]. After > that series was not merged i decided to get my patches ready. The > original series aimed at being generic for any sort of signing tool, while > this series just introduced the X509 variant of gpg. (gpgsm) > I collected authors and reviewers of that first series and already put them > on cc. This series is a fine replacement for that earlier work. It's flexible enough to allow what we really wanted out of that series (gpgsm support, or another drop-in tool that uses the same interface). It doesn't lay any groundwork for further tools (like signify), but I think the consensus on the list was to punt on that until somebody had more concrete plans for adding such a tool. -Peff
