On Fri, Jul 6, 2018 at 12:36 AM Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > On Thu, Jul 5, 2018 at 8:54 PM Derrick Stolee <stolee@xxxxxxxxx> wrote: > > +test_expect_success 'write midx with one v1 pack' ' > > + pack=$(git pack-objects --index-version=1 pack/test <obj-list) && > > + test_when_finished rm pack/test-$pack.pack pack/test-$pack.idx pack/multi-pack-index && > > + git multi-pack-index --object-dir=. write && > > + midx_read_expect > > +' > > It's odd to see all these tests ending by creating an 'expect' file > but not actually doing anything with that file. Ignore this comment. As mentioned in my follow-up to 6/24, I missed the fact that midx_read_expect() is doing more than just creating the 'expect' file.
