On Thu, Jul 5, 2018 at 8:54 PM Derrick Stolee <stolee@xxxxxxxxx> wrote:
> Signed-off-by: Derrick Stolee <dstolee@xxxxxxxxxxxxx>
> ---
> diff --git a/midx.c b/midx.c
> @@ -18,9 +18,10 @@
> @@ -384,6 +391,32 @@ static size_t write_midx_pack_names(struct hashfile *f,
> +static size_t write_midx_oid_lookup(struct hashfile *f, unsigned char hash_len,
> + struct pack_midx_entry *objects,
> + uint32_t nr_objects)
> +{
> + struct pack_midx_entry *list = objects;
> + uint32_t i;
> + size_t written = 0;
> +
> + for (i = 0; i < nr_objects; i++) {
> + struct pack_midx_entry *obj = list++;
> +
> + if (i < nr_objects - 1) {
> + struct pack_midx_entry *next = list;
> + if (oidcmp(&obj->oid, &next->oid) >= 0)
> + BUG("OIDs not in order: %s >= %s",
> + oid_to_hex(&obj->oid),
> + oid_to_hex(&next->oid));
The above two lines are arguments to BUG(), thus should be indented more.
> + }
> +
