Jeff King <peff@xxxxxxxx> writes: > On Mon, Jul 02, 2018 at 03:08:54PM -0500, Taylor Blau wrote: > >> Attached is the second re-roll of my series to teach 'git grep >> --only-matching'. Since last time, not much has changed. The change I >> did include is summarized below, and an inter-diff is attached as >> always. >> >> - Initialize both match_color and line_color to NULL, thereby >> silencing a compiler warning where match_color was given to >> opt->output_color uninitialized [1]. > > This iteration looks fine to me. I think we'd ideally do > s/grep/& --column/ in the commit message of the second patch, but that's > not worth re-rolling. I'm OK doing this myself while queuing: - $ git grep -no -e git -- README.md | grep ":27" + $ git grep -n --only-matching --column -e git -- README.md | grep ":27" but the lack of changes to Documentation/git-grep.txt makes the topic worth rerolling anyway (I needed to look up what "-no" means there, and then found there was no such option in the manpage ;-).
