On Tue, Jul 03, 2018 at 10:37:29AM -0400, Jeff King wrote: > On Mon, Jul 02, 2018 at 03:08:54PM -0500, Taylor Blau wrote: > > > Attached is the second re-roll of my series to teach 'git grep > > --only-matching'. Since last time, not much has changed. The change I > > did include is summarized below, and an inter-diff is attached as > > always. > > > > - Initialize both match_color and line_color to NULL, thereby > > silencing a compiler warning where match_color was given to > > opt->output_color uninitialized [1]. > > This iteration looks fine to me. I think we'd ideally do > s/grep/& --column/ in the commit message of the second patch, but that's > not worth re-rolling. In the example it shows, I mean (a global s/ would not be good ;) ). -Peff
