Re: [PATCH 17/29] t: use test_must_fail() instead of checking exit code manually

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 17/29] t: use test_must_fail() instead of checking exit code manually
From: Johannes Sixt <j6t@xxxxxxxx>
Date: Tue, 26 Jun 2018 23:00:24 +0200
Cc: Elijah Newren <newren@xxxxxxxxx>, Git List <git@xxxxxxxxxxxxxxx>, Jeff King <peff@xxxxxxxx>, Jonathan Nieder <jrnieder@xxxxxxxxx>, SZEDER Gábor <szeder@xxxxxxxxxx>, Stefan Beller <sbeller@xxxxxxxxxx>, Jonathan Tan <jonathantanmy@xxxxxxxxxx>
In-reply-to: <CAPig+cRnbW9fRh68ZorNQHjDFHQBWmqfEPSO+H7qgMJVOcbJmQ@mail.gmail.com>
References: <20180626073001.6555-1-sunshine@sunshineco.com> <20180626073001.6555-18-sunshine@sunshineco.com> <CABPp-BFmfN6=E+3BAKt-NH5hmU-368shgDnrnkrnMRvKnx07BQ@mail.gmail.com> <CAPig+cRTG625H3CF1Zw30vQt2W8uKf1xLxVaQni2YbJ=xAif2g@mail.gmail.com> <29d090a2-bbe4-0d87-6dda-037ae675d4a3@kdbg.org> <CAPig+cRnbW9fRh68ZorNQHjDFHQBWmqfEPSO+H7qgMJVOcbJmQ@mail.gmail.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

Am 26.06.2018 um 20:14 schrieb Eric Sunshine:

On Tue, Jun 26, 2018 at 2:06 PM Johannes Sixt <j6t@xxxxxxxx> wrote:

Hence, these lines should actually be

                 p4 help client &&
                 ! p4 help nosuchcommand


Thanks for the comment; you're right, of course. I'll certainly make
this change if I have to re-roll for some other reason, but do you
feel that this itself is worth a re-roll?


Not worth a re-roll IMO.

-- Hannes

References:
- [PATCH 00/29] t: detect and fix broken &&-chains in subshells
  - From: Eric Sunshine
- [PATCH 17/29] t: use test_must_fail() instead of checking exit code manually
  - From: Eric Sunshine
- Re: [PATCH 17/29] t: use test_must_fail() instead of checking exit code manually
  - From: Elijah Newren
- Re: [PATCH 17/29] t: use test_must_fail() instead of checking exit code manually
  - From: Eric Sunshine
- Re: [PATCH 17/29] t: use test_must_fail() instead of checking exit code manually
  - From: Johannes Sixt
- Re: [PATCH 17/29] t: use test_must_fail() instead of checking exit code manually
  - From: Eric Sunshine

Prev by Date: Re: [PATCH 29/29] t/test-lib: teach --chain-lint to detect broken &&-chains in subshells
Next by Date: Re: [PATCH 29/29] t/test-lib: teach --chain-lint to detect broken &&-chains in subshells
Previous by thread: Re: [PATCH 17/29] t: use test_must_fail() instead of checking exit code manually
Next by thread: [PATCH 07/29] t7201: drop pointless "exit 0" at end of subshell
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]