On Wed, Jun 13, 2018 at 1:21 PM Todd Zullinger <tmz@xxxxxxxxx> wrote: > Eric Sunshine wrote: > > Since you're touching all the tests in this script anyhow, perhaps > > modernize them [...] > > (Not necessarily worth a re-roll.) > > These tests were based on similar test_external tests which > use perl. like t0202 & t9700. Both examples use the same > formatting (and use of 'set up'). Perhaps a later clean up > can adjust all three tests? Whichever course of action works for you and Junio is fine. In this case, it's such a minor bit of additional work to modernize the two tests in this script that it would make sense to do so in this patch if you happen to re-roll (and if you agree with me), but is itself probably not worth a re-roll (as mentioned above).
