On Tue, Jun 12, 2018 at 11:10 PM, Todd Zullinger <tmz@xxxxxxxxx> wrote:
> Signed-off-by: Todd Zullinger <tmz@xxxxxxxxx>
> ---
> diff --git a/contrib/credential/netrc/t-git-credential-netrc.sh b/contrib/credential/netrc/t-git-credential-netrc.sh
> index 58191a62f8..c5661087fe 100755
> --- a/contrib/credential/netrc/t-git-credential-netrc.sh
> +++ b/contrib/credential/netrc/t-git-credential-netrc.sh
> @@ -17,15 +17,15 @@
> # set up test repository
>
> test_expect_success \
> - 'set up test repository' \
> - 'git config --add gpg.program test.git-config-gpg'
> + 'set up test repository' \
> + 'git config --add gpg.program test.git-config-gpg'
Since you're touching all the tests in this script anyhow, perhaps
modernize them so the title and opening quote of the test body are on
the same line as test_expect_success, and the closing body quote is on
a line of its own?
test_expect_sucess 'setup test repository' '
...test body...
'
I also changed "set up" to "setup" to follow existing practice.
(Not necessarily worth a re-roll.)
> # The external test will outputs its own plan
> test_external_has_tap=1
>
> test_external \
> - 'git-credential-netrc' \
> - perl "$TEST_DIRECTORY"/../contrib/credential/netrc/test.pl
> + 'git-credential-netrc' \
> + perl "$TEST_DIRECTORY"/../contrib/credential/netrc/test.pl
>
> test_done
> )
