On Sun, Jun 10, 2018 at 06:07:27PM +0300, Max Kirillov wrote: > On Mon, Jun 04, 2018 at 12:44:09AM -0400, Jeff King wrote: > > On Sun, Jun 03, 2018 at 12:27:49AM +0300, Max Kirillov wrote: > >> + env \ > >> + CONTENT_TYPE=application/x-git-upload-pack-request \ > >> + QUERY_STRING=/repo.git/git-upload-pack \ > >> + PATH_TRANSLATED="$PWD"/.git/git-upload-pack \ > >> + GIT_HTTP_EXPORT_ALL=TRUE \ > >> + REQUEST_METHOD=POST \ > >> + CONTENT_LENGTH="$NOT_FIT_IN_SSIZE" \ > >> + git http-backend </dev/zero >/dev/null 2>err && > >> + grep -q "fatal:.*CONTENT_LENGTH" err > > > > I'm not sure if these messages should be marked for translation. If so, > > you'd want test_i18ngrep here. > > Message localization does not seem to be used in > http-backend at all. It makes sense - server-side software > probably does not know who is the user on the other side, if > the message gets to the user at all. So, I think the > message should not be translated. OK. I think there's been talk of localizing "fatal:", but whoever does that patch would have to deal with fallout all over the test-suite. I don't think we need to worry about it yet. -Peff
