Hi Junio, On Mon, 21 May 2018, Johannes Schindelin wrote: > On Fri, 18 May 2018, SZEDER Gábor wrote: > > > > > So, I think for v2 I will rewrite these tests to call > > > > __git_complete_index_file() directly instead of using > > > > 'test_completion', and will include a test with spaces in path > > > > names. > > > > > > Quite well thought-out reasoning. Thanks. > > > > Unfortunately I couldn't get around to it soon enough, and now the topic > > 'sg/complete-paths' is already in next, so here are those test > > improvements on top. > > I can verify that the weeks-long breakage of `pu` on Windows has been > addressed, probably by this patch series. Please note that as the branch that is fixed by these two patches was already merged down to `next`, the Continuous Testing on Windows reports that `next` is broken. (I saw that breakage for over a week, but was too busy elsewhere to act on it.) It would be really lovely to see it fixed soon, so that other bugs cannot be hidden by that breakage. And I would also love to see sg/complete-paths to be merged down to `master` *only* in conjunction with these two patches, not on its own (because that would break the Continuous Testing on Windows of `master`, which is something I really want us to avoid). Thanks, Dscho
