> > So, I think for v2 I will rewrite these tests to call > > __git_complete_index_file() directly instead of using > > 'test_completion', and will include a test with spaces in path names. > > Quite well thought-out reasoning. Thanks. Unfortunately I couldn't get around to it soon enough, and now the topic 'sg/complete-paths' is already in next, so here are those test improvements on top. SZEDER Gábor (2): completion: don't return with error from __gitcomp_file_direct() t9902-completion: exercise __git_complete_index_file() directly contrib/completion/git-completion.bash | 6 +- t/t9902-completion.sh | 225 +++++++++++++------------ 2 files changed, 122 insertions(+), 109 deletions(-) -- 2.17.0.799.gd371044c7c
