Jeff King <peff@xxxxxxxx> writes: > On Tue, Apr 17, 2018 at 12:12:12AM +0000, brian m. carlson wrote: > >> > That argues more strongly that we would regret unless we make the >> > end-user configuration to at least the whole string (which later can >> > be promoted to "a pattern that matches the whole string"), not just >> > the part after mandatory "-----BEGIN ", methinks. >> >> Yeah, I think this patch set is "add gpgsm support", which I can see as >> a valuable goal in and of itself, but I'm not sure the attempt to make >> it generic is in the right place. If we want to be truly generic, the >> way to do that is to invoke a helper based on signature type (e.g. >> git-sign-gpg, git-sign-gpgsm, git-sign-signify) to do the signing and >> verification. We need not ship these helpers ourselves; interested >> third-parties can provide them, and we can add configuration to match >> against regexes for non-built-in types (which is required for many other >> formats). > > Isn't that basically what this patch is, though? Or at least a step in > that direction? I think that is what Brian is saying, too (and if so I would also agree). It probably is a good step. It is just the feature may be sold under a wrong (or, overly wide) label, perhaps?
