On 6/9/07, Johan Herland <johan@xxxxxxxxxxx> wrote:
This patch introduces a new optional header line to the tag object, called
"keywords". The "keywords" line may contain a comma-separated list of
custom keywords associated with the tag object.
What is the character set for the keywords?
+ for (i = 0; i < keywords_len; ++i) {
+ unsigned char c = keywords_line[i];
+ if (c == ',' && keywords_line[i + 1] == ',')
+ /* consecutive commas */
+ return error("Tag object (@ char "
+ PD_FMT "): Found empty keyword",
+ keywords_line + i - data);
+ if (c > ' ' && c != 0x7f)
+ continue;
And what is so special about 0x7f?
+ if (keywords_len) { /* optional keywords string was given */
+ item->keywords = xmalloc(keywords_len + 1);
Who frees the keywords and what's wrong with strndup?
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
