On Tue, May 01, 2018 at 02:23:51PM +0200, Matthieu Moy wrote: > I'm fine with it as-is. Before your "fix", the config was ignored > because overwritten by init_diff_ui_defaults() after reading the > config, so effect of your change is indeed what the commit message > describes. > > I'm often thinking aloud while reviewing, don't take my comments as > objections. No worries, I was wondering while writing the patch to extract it - the init should be changed to the appropriate location even if there is consensus to leave all the other knobs as they are, shouldn't it? Greetings, Eckhard
