On Tue, May 01, 2018 at 01:09:06PM +0200, Matthieu Moy wrote: > That init_diff_ui_defaults() should indeed have been before > git_config() from the beginning. My bad, I'm the one who > misplaced it apparently :-(. Should I have done this "bug fix" in a separate commit or mention it in the commit message? > This "break_opt = 0" deserves a mention in the commit message IMHO. > I'm not 100% sure it's a good change actually. Hm, what problems do you see here? The purpose of my patch is have the same kind of output from git status and, after commit, git show. I cannot find a good reason for git status to behave there differently, but I am interested to see where I am wrong. On the other hand, one could a configuration option to the diff.* family for controlling that toggle also. Greetings, Eckhard
