Re: [PATCH 02/41] server-info: remove unused members from struct pack_info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 24 April 2018 at 01:39, brian m. carlson
<sandals@xxxxxxxxxxxxxxxxxxxx> wrote:
> The head member of struct pack_info is completely unused and the
> nr_heads member is used only in one place, which is an assignment.
> Since these structure members are not useful, remove them.

Good catch.

> @@ -228,7 +226,6 @@ static void init_pack_info(const char *infofile, int force)
>         for (i = 0; i < num_pack; i++) {
>                 if (stale) {
>                         info[i]->old_num = -1;
> -                       info[i]->nr_heads = 0;
>                 }
>         }

Minor nits: The braces could go. Not something you're introducing, but
the nesting of the `for` and the `if` looks odd. There used to be more
inside this loop, which explains this.

Martin



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux