On 24 April 2018 at 01:39, brian m. carlson <sandals@xxxxxxxxxxxxxxxxxxxx> wrote: > In various places throughout the codebase, we need to read data into a > struct object_id from a pack or other unsigned char buffer. Add an > inline function that does this based on the current hash algorithm in > use, and use it in several places. Makes sense. Grepping for "memcpy.*hash" turns up a few instances that look similar, but not quite, so we would *not* want to do this conversion there, e.g., hashmap.h and notes.c. Martin