On Sun, Apr 22, 2018 at 08:21:33PM -0400, Eric Sunshine wrote: > On Sun, Apr 22, 2018 at 7:24 PM, Taylor Blau <me@xxxxxxxxxxxx> wrote: > > On Sun, Apr 22, 2018 at 11:42:48PM +0200, Ęvar Arnfjörš Bjarmason wrote: > >> On Sun, Apr 22 2018, Taylor Blau wrote: > >> > In preparation of adding --column-number to 'git-grep(1)', we extend > >> > grep_opt to take in the requisite new members. > >> > >> Just a nit: Makes sense to refer to these camel-cased in docs & commit > >> messages. > > > > Could you clarify which? I am not sure if you mean --column-number, > > 'git-grep(1)', or grep_opt. > > I think Ævar was referring to this bit from the commit message (which > unfortunately got snipped in his review): > > We additionally teach the 'grep.columnnumber' and > 'color.grep.columnnumber' configuration variables to configure > showing and coloring the column number, respectively. (These > options remain undocumented until 'git-grep(1)' learns the > --column option in a forthcoming commit.) > > He was suggesting camel-casing 'grep.columnNumber' and > 'color.grep.columNumber' even in the commit message. Thanks for the clarification, Eric. I have amended my copy of this patch to correctly case those variables. Thanks, Taylor
