On Sun, Apr 22 2018, Taylor Blau wrote: I think [345]/6 would make much more sense as just one patch. Comments on them to follow... > In preparation of adding --column-number to 'git-grep(1)', we extend > grep_opt to take in the requisite new members. Just a nit: Makes sense to refer to these camel-cased in docs & commit messages. > diff --git a/grep.c b/grep.c > [...] All of the boilerplate looks fine.