On Fri, 8 Jun 2007, Johan Herland wrote: > I agree that we should fail gracefully, and my code is clearly not doing > that in this case. My bad. > > But the code should also detect invalid tag objects, and in this case I'm > not yet convinced that the tag object causing the failure is in fact valid. > If someone can convince me that the blank line after headers is optional, > then I'll gladly fix the code. That's irrelevant. Because you are fed invalid data is no excuse for crashing. Especially in a tool like fsck, you should _expect_ and cope with invalid data. That's why it exists in the first place: to identify such data. Nicolas - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
