Re: [PATCH] fsck: do not crash on tag objects which do not contain an empty line

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, 8 Jun 2007, Johan Herland wrote:

> On Friday 08 June 2007, Johannes Schindelin wrote:
> > 
> > The first empty line in a tag object separates the header from the 
> > message. If the tag object has no empty line, do not crash, but 
> > complain loudly instead.
> 
> Aren't tag objects _required_ to have an empty line separating the 
> headers from the body? At least I wrote the new tag code with that 
> assumption in mind.

Yes, evidently you did.

But even then, isn't it always better to not rely on such assumptions, but 
fail gracefully? The rest of Git's source code seems to be nicer to 
failures as this one, IMHO.

> Could this be related to the "error: char103: premature end of data" 
> you're seeing?

Definitely. It breaks even _fetching_.

Ciao,
Dscho

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux