On 03/27, Eric Sunshine wrote: > On Sun, Mar 25, 2018 at 9:49 AM, Thomas Gummerer <t.gummerer@xxxxxxxxx> wrote: > > The 'force_new_branch' flag in 'struct add_opts' is only used inside the > > add function, where we already have the same information stored in the > > 'new_branch_force' variable. Avoid that unnecessary duplication. > > When I was reviewing your original dwim-ery series (inferring 'foo' > from 'origin/foo'), I noticed that 'struct add_opts' had accumulated a > number of unnecessary members over time, including this one. My plan > was to submit a patch removing all those pointless members after your > dwim-ery series settled, however, I never got around to it. Ah right, I didn't look at them in detail, so I failed to notice that. While I'm already in the area I may as well do that, thanks for the suggestion! > This patch might be a good opportunity for doing that cleanup > wholesale, removing all unneeded members rather than just the one. (If > so, you'd probably want to move to this patch to the front of the > series as cleanup before the meatier changes.) Anyhow, it's just a > thought; feel free to respond with "it's outside the scope of this > series" if you're not interested in doing it. > > > Signed-off-by: Thomas Gummerer <t.gummerer@xxxxxxxxx>
