On Wed, 28 Mar 2018 10:24:43 -0700 Stefan Beller <sbeller@xxxxxxxxxx> wrote: > * picked up Jonathans patch and added it as a nice finish of the series. > I did not see the need or aesthetic desire to put that patch earlier > in the series. Thanks for picking up my patch. The aesthetic desire is to avoid what's currently happening in PATCH 2/6 version 2, where we still have the potentially confusing submodule_free() -> submodule_free(repo) conversion, which is also later redone in PATCH 6/6 version 2 (submodule_free(repo) -> submodule_free(the_repository)). But I'll leave the final decision to you. Other than that, besides PATCH 5/6 (which I have already commented on), everything looks good.
