On Tue, 27 Mar 2018 14:39:17 -0700 Stefan Beller <sbeller@xxxxxxxxxx> wrote: > This continues the story of bf12fcdf5e (submodule-config: store > the_submodule_cache in the_repository, 2017-06-22). > > The previous patch taught submodule_from_path to take a repository into > account, such that submodule_from_{path, cache} are the same now. > Remove submodule_from_cache, migrating all its callers to > submodule_from_path. > > Signed-off-by: Stefan Beller <sbeller@xxxxxxxxxx> Obviously correct, since submodule_from_{path,cache} are word-for-word identical (other than parameter names). Reviewed-by: Jonathan Tan <jonathantanmy@xxxxxxxxxx>