On Tue, 27 Mar 2018 14:39:16 -0700
Stefan Beller <sbeller@xxxxxxxxxx> wrote:
> -extern const struct submodule *submodule_from_name(
> +extern const struct submodule *submodule_from_name(struct repository *r,
> const struct object_id *commit_or_tree, const char *name);
> -extern const struct submodule *submodule_from_path(
> +extern const struct submodule *submodule_from_path(struct repository *r,
> const struct object_id *commit_or_tree, const char *path);
There is a recent change to CodingGuidelines that states to not include
"extern" in 89a9f2c862 ("CodingGuidelines: mention "static" and
"extern"", 2018-02-08), so consider removing "extern" since you're
already changing this file.
Other than that,
Reviewed-by: Jonathan Tan <jonathantanmy@xxxxxxxxxx>
