Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:
> If you fold this into the previous patch, I am sure that after your 3/9
> indenting the function properly, the splitting into functions will look
> more or less like this:
>
> -git_rebase__interactive () {
> +initiate_action () {
> + action="$1"
>
> [... unchanged code ...]
> +}
> +
> +<next function> () {
> + [... setting up variables ...]
>
> [.. unchanged code ...]
> +}
> [... more of the same ...]
> +
> +git_rebase__interactive () {
> + initiate_action "$action" &&
> + <next function> <arguments> &&
> + ...
> +}
>
> In other words, it would be easier to review and to verify that the
> previous code is left unchanged (although that would have to be verified
> manually by applying 3/9 and then looking at the diff with the -w option,
> anyway).
We are on the same page on this. A series structured to have a step
that looks exactly like the above would be very pleasant to review.
Thanks for a great suggestion.
