Hi Wink,
On Thu, 22 Mar 2018, Wink Saville wrote:
> Use initiate_action, setup_reflog_action, init_basic_state,
> init_revisions_and_shortrevisions and complete_action.
>
> Signed-off-by: Wink Saville <wink@xxxxxxxxxxx>
> ---
> git-rebase--interactive.sh | 187 ++-------------------------------------------
If you fold this into the previous patch, I am sure that after your 3/9
indenting the function properly, the splitting into functions will look
more or less like this:
-git_rebase__interactive () {
+initiate_action () {
+ action="$1"
[... unchanged code ...]
+}
+
+<next function> () {
+ [... setting up variables ...]
[.. unchanged code ...]
+}
[... more of the same ...]
+
+git_rebase__interactive () {
+ initiate_action "$action" &&
+ <next function> <arguments> &&
+ ...
+}
In other words, it would be easier to review and to verify that the
previous code is left unchanged (although that would have to be verified
manually by applying 3/9 and then looking at the diff with the -w option,
anyway).
Ciao,
Johannes
