On Wed, Mar 21, 2018 at 2:11 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Pratik Karki <predatoramigo@xxxxxxxxx> writes: >> Avoid using pipes downstream of Git commands since the exit >> codes of commands upstream of pipes get swallowed, thus potentially hiding >> failure of those commands. Instead, capture Git command output to a file and >> apply the downstream command(s) to that file. > > Please do not indent the body of the log message by one space. One other issue I forgot to mention is that the commit message in v3 started getting too wide again[1]; it was fine in v2. Pratik, try to keep the commit message wrapped to about 70-72 characters or so. [1]: https://public-inbox.org/git/CAPig+cRPzyw525ODC4=-E7w=zbpbhVN2eqxSYDSLij5wfW8S_A@xxxxxxxxxxxxxx/
