Hi Junio, On Wed, 14 Mar 2018, Junio C Hamano wrote: > Phillip Wood <phillip.wood@xxxxxxxxxxxx> writes: > > > From: Phillip Wood <phillip.wood@xxxxxxxxxxxxx> > > > > This allows one to run 'git rebase --exec "make check" --signoff' > > which is useful when preparing a patch series for publication and is > > more convenient than doing the signoff with another --exec command. > > This change also allows --root without --onto to work with --signoff > > as well (--root with --onto was already supported). Note that the > > failing test is due to a bug in 'rebase --root' when the root commit > > is empty which will be fixed in the next commit. > > > > Signed-off-by: Phillip Wood <phillip.wood@xxxxxxxxxxxxx> > > --- > > How important is the word "implicit" in the title? Is it your > intention to actively ignore --signoff when we fall into the > rebase--interactive codepath explicitly? The patch makes the explicit case fail ;-) > I offhand do not think of a strong reason why it is a bad idea to > run "git rebase -i --signoff", turn a few "pick" to either "reword" > or "edit", and then expect that the editor to edit log messages for > these commits to add your sign-off when you start editing them. > The "pick"s that are left as-is would also turn into doing an > otherwise no-op "commit --amend -s", I guess. > > If you are teaching --signoff to the whole of "rebase--interactive", > then "git rebase --help" needs a bit of update. > > --signoff:: > This flag is passed to 'git am' to sign off all the rebased > commits (see linkgit:git-am[1]). Incompatible with the > --interactive option. Good point. I'd actually be in favor of having all rebase modes support --signoff, but I do not want to pile onto Phillip's workload. Ciao, Dscho
