Igor Djordjevic <igor.d.djordjevic@xxxxxxxxx> writes: > Hi Dscho, > > On 07/03/2018 08:26, Johannes Schindelin wrote: [...] >> Second side note: if we can fast-forward, currently we prefer that, and I >> think we should keep that behavior with -R, too. > > I agree. I'm admittedly somewhat lost in the discussion, but are you talking fast-forward on _rebasing_ existing merge? Where would it go in any of the suggested algorithms of rebasing and why? I readily see how it can break merges. E.g., any "git merge --ff-only --no-ff" merge will magically disappear. So, even if somehow supported, fast-forward should not be performed by default during _rebasing_ of a merge. >> If the user wants to force a new merge, they simply remove that -R >> flag. Alternatively, they'd replace 'pick' with 'merge', as they already do for other actions. "A plurality is not to be posited without necessity". Please, _please_, don't use 'merge' command to 'pick' merge commits! It's utterly confusing! Thinking about it I've got an idea that what we actually need is --no-flatten flag that, when used alone, will just tell "git rebase" to stop flattening history, and which will be implicitly imposed by --recreate-merges (and --preserve-merges). Then the only thing the --recreate-merges will tune is to put 'merge' directives into the todo list for merge commits, exactly according to what its name suggests, while the default behavior will be to put 'pick' with suitable syntax into the todo. And arguments to the --recreate-merge will specify additional options for the 'merge' directive, obviously. -- Sergey
