On Fri, Feb 23, 2018 at 1:19 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Duy Nguyen <pclouds@xxxxxxxxx> writes: > >> Now that you mention it, the only command that completes >> --rerere-autoupdate is git-merge. Since this is "auto" I don't think >> people want to type manually. > > Sorry, but I do not quite get the connection between "since this is > 'auto'" and the rest of the sentence. Is it just it is so lengthy > that people do not want to type and are likely to use completion? Well, if it is to be done automatically, I should not need to tell it manually (by typing the option on command line). Granted it's a weak argument. >> Maybe I should separate these changes >> _and_ remove --rerere-autoupdate from _git_merge() too? At least that >> it will be consistent that way. > > Hmmmm. Why not complete this option? Is it because the current > completion script does not and we are trying to preserve the > behaviour? I do not have a strong opinion either way, but just > trying to understand the reasoning behind the choice. There's not a strong argument for not completing this option really. It may belong to the unpopular category and adding it may make people <TAB> more for other options. But I think it's way too early to decide that. And even if that's true, I think we should let the user choose to not complete certain options they don't like. It's good that this is spotted. I think I'll just keep all --rerere-autoupdate completable. Well, v4's coming (in a few days)... -- Duy
