Duy Nguyen <pclouds@xxxxxxxxx> writes:
> Now that you mention it, the only command that completes
> --rerere-autoupdate is git-merge. Since this is "auto" I don't think
> people want to type manually.
Sorry, but I do not quite get the connection between "since this is
'auto'" and the rest of the sentence. Is it just it is so lengthy
that people do not want to type and are likely to use completion?
> Maybe I should separate these changes
> _and_ remove --rerere-autoupdate from _git_merge() too? At least that
> it will be consistent that way.
Hmmmm. Why not complete this option? Is it because the current
completion script does not and we are trying to preserve the
behaviour? I do not have a strong opinion either way, but just
trying to understand the reasoning behind the choice.
>>> diff --git a/rerere.h b/rerere.h
>>> index c2961feaaa..5e5a312e4c 100644
>>> --- a/rerere.h
>>> +++ b/rerere.h
>>> @@ -37,6 +37,7 @@ extern void rerere_clear(struct string_list *);
>>> extern void rerere_gc(struct string_list *);
>>>
>>> #define OPT_RERERE_AUTOUPDATE(v) OPT_UYN(0, "rerere-autoupdate", (v), \
>>> - N_("update the index with reused conflict resolution if possible"))
>>> + N_("update the index with reused conflict resolution if possible"), \
>>> + PARSE_OPT_NOCOMPLETE)
>>>
>>> #endif
>>> --
>>> 2.16.1.207.gedba492059
>>>
