> On 16 Feb 2018, at 19:55, Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Jeff King <peff@xxxxxxxx> writes: > >> So a full proposal would support both cases: "check this out in the >> local platform's preferred encoding" and "always check this out in >> _this_ encoding". And Lars's proposal is just the second half of that. > > Actually, what you seem to take as a whole is just half of the > story. The other half that is an ability to say "what is in the > repository for this path is stored in this encoding". I agree that > "check it out in this encoding" is a useful thing to have, and using > the in-tree .gitattributes as a place to state the project-wide > preference may be OK (and .git/info/attributes should be able to > override it if needed -- this probably deserves to be added to a > test somewhere by this series). Good call! I'll add this test case! > Luckily, lack of 'in-repository-encoding' attribute is not a show > stopper for this series. A later topic could start with "earlier, > in order to make use of w-t-e attribute, you had to have your > contents in UTF-8. Teach the codepath to honor a new attribute that > tells in what encoding the blob contents are stored." without having > to be a part of this topic. I have the impression that this is the purpose of the already existing "encoding" attribute, no? AFAIK this attribute is only respected by gitk, though. A future series could make Git respect this attribute too. - Lars
