Get rid of goto command in ref-filter for better readability. Signed-off-by: Olga Telezhnaia <olyatelezhnaya@xxxxxxxxx> Mentored-by: Christian Couder <christian.couder@xxxxxxxxx> Mentored by: Jeff King <peff@xxxxxxxx> --- ref-filter.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ref-filter.c b/ref-filter.c index 83ffd84affe52..28df6e21fb996 100644 --- a/ref-filter.c +++ b/ref-filter.c @@ -1494,11 +1494,11 @@ static void populate_value(struct ref_array_item *ref) for (i = 0; i < used_atom_cnt; i++) { struct atom_value *v = &ref->value[i]; if (v->s == NULL) - goto need_obj; + break; } - return; + if (used_atom_cnt <= i) + return; - need_obj: get_object(ref, &ref->objectname, 0, &obj); /* -- https://github.com/git/git/pull/460