Derrick Stolee <stolee@xxxxxxxxx> writes:
> +int cmd_commit_graph(int argc, const char **argv, const char *prefix)
> +{
> + static struct option builtin_commit_graph_options[] = {
> + { OPTION_STRING, 'p', "object-dir", &opts.obj_dir,
> + N_("dir"),
> + N_("The object directory to store the graph") },
I have a suspicion that this was modeled after some other built-in
that has a similar issue (perhaps written long time ago), but isn't
OPT_STRING() sufficient to define this element these days?
Or am I missing something?
Why squat on short-and-sweet "-p"? For that matter, since this is
not expected to be end-user facing command anyway, I suspect that we
do not want to allocate a single letter option from day one, which
paints ourselves into a corner from where we cannot escape.
