On Fri, Feb 16, 2018 at 02:25:41PM -0500, Jeff King wrote: > On Fri, Feb 16, 2018 at 10:55:58AM -0800, Junio C Hamano wrote: > > > Jeff King <peff@xxxxxxxx> writes: > > > > > So a full proposal would support both cases: "check this out in the > > > local platform's preferred encoding" and "always check this out in > > > _this_ encoding". And Lars's proposal is just the second half of that. > > > > Actually, what you seem to take as a whole is just half of the > > story. The other half that is an ability to say "what is in the > > repository for this path is stored in this encoding". I agree that > > "check it out in this encoding" is a useful thing to have, and using > > the in-tree .gitattributes as a place to state the project-wide > > preference may be OK (and .git/info/attributes should be able to > > override it if needed -- this probably deserves to be added to a > > test somewhere by this series). > > If we are just talking about a check-out feature, I'm not sure that the > in-repository encoding is all that interesting. As with CRLFs, we would > be declaring UTF-8 as the "canonical" in-repo encoding for such > conversions. Is there a reason you'd want something else? Maybe answering my own question: because your encoding of choice does not round-trip to UTF-8? In which case yeah, I could see choosing an in-repo encoding to possibly be useful (but it also seems like a feature that could easily be tacked on later if somebody cares). -Peff
