On 5/30/07, Johannes Sixt <J.Sixt@xxxxxxxxxxxxx> wrote:
This looks wrong. NEEDS_SOCKET is set in the architecture sections of Makefile where necessary, but the MinGW section doesn't want it and doesn't set it. If ./configure sets it, then you should fix configure.ac, not work around in Makefile.
I did so because I didn't have SunOS to test so I'd rather not touch the code detecting NEEDS_SOCKET in configure.ac. How about this patch: diff --git a/configure.ac b/configure.ac index 4a12cb0..0516fdb 100644 --- a/configure.ac +++ b/configure.ac @@ -173,6 +173,12 @@ test -n "$NEEDS_LIBICONV" && LIBS="$LIBS -liconv" AC_CHECK_LIB([c], [socket], [NEEDS_SOCKET=], [NEEDS_SOCKET=YesPlease]) +if test "$NEEDS_SOCKET" = YesPlease; then # more check + AC_CHECK_LIB([socket], [socket], + [LIBSOCKET_HAS_SOCKET=], + [LIBSOCKET_HAS_SOCKET=1]) + test -n "$LIBSOCKET_HAS_SOCKET" && NEEDS_SOCKET= +fi AC_SUBST(NEEDS_SOCKET) test -n "$NEEDS_SOCKET" && LIBS="$LIBS -lsocket" If someone has a SunOS, please test the above patch. Thanks -- Duy - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
