Re: [PATCH 4/4] Don't link with libsocket in MINGW port

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"Nguy�n Thái Ng�c Duy" wrote:
> 
> From: Nguy�n Thái Ng�c Duy <pclouds@xxxxxxxxx>
> 
> There is a check in configure.ac to determine if libc has function
> socket(). It is used to link with libsocket on SunOS.
> 
> On Windows, libc does not have socket() as well but it is provided
> by winsock, not libsocket. So don't link with libsocket if you are
> on Windows.

>  ifdef NEEDS_SOCKET
> +ifndef MINGW
>         EXTLIBS += -lsocket
>  endif
> +endif

This looks wrong. NEEDS_SOCKET is set in the architecture sections of
Makefile where necessary, but the MinGW section doesn't want it and
doesn't set it. If ./configure sets it, then you should fix
configure.ac, not work around in Makefile.

-- Hannes

PS: Appologies for the mangled name - this MUA is from the stone age.

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux