On Fri, Jan 19, 2018 at 3:22 AM, Duy Nguyen <pclouds@xxxxxxxxx> wrote: > On Fri, Jan 19, 2018 at 2:40 PM, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: >> On Fri, Jan 19, 2018 at 12:31:58PM +0700, Duy Nguyen wrote: >>> On Linux, after I hacked all over the place to force ce_match_stat() >>> to eventually call index_fd() which in turns must use one of the >>> hashing function, I got a crash. >> >> Nice detective work. > > And not stepping back to think for a bit. I realized now that if I > just mounted a vfat filesystem, I could have verified it much quicker. > It does crash on linux with similar stack trace. > [...] >> This particular manifestation is caught by the >> following test which fails without brian's patch on MacOS (and >> presumably Windows) and succeeds with it. On Linux and BSD, it will of >> course succeed always, so I'm not sure how much practical value it >> has. > > There's a travis job running "on windows" (I don't what it really > means) so it might help actually. This vim-colorschemes repository has > shown up in git mailing list before, I think. We probably should just > add it as part of our regression tests ;-) And, Dscho does run the test suite on Windows regularly, so perhaps this test does have some practical value.
