On Thu, Jan 18, 2018 at 10:06:10PM -0500, Eric Sunshine wrote: > > I have a guess about what the problem might be. Can you try this patch > > and see if it fixes things? > > That does fix the crash. Thanks for the quick diagnosis. > > Can the commit message go into more detail as to why this was crashing > (or your speculation about why)? Perhaps give more detail about what > 'clone' is doing that led to the crash. Sure. I ran into this as I was expanding the hash structure abstraction into my next series. I'll send a follow-up patch with a more descriptive answer. I'm still extremely puzzled as to why this doesn't fail on Linux. If it's failing in this case, it should very, very clearly fail all the time we access an empty blob or an empty tree. I've tried with gcc and two versions of clang, using -fno-lto, with address sanitizer, with -O0, and so on. I'd really like to catch this kind of issue sooner in the future if I can figure out how to reproduce it. -- brian m. carlson / brian with sandals: Houston, Texas, US https://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: https://keybase.io/bk2204
Attachment:
signature.asc
Description: PGP signature
