Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxx> writes: > Alex Bennée <alex.bennee@xxxxxxxxxx> writes: > >> I think you need to apply Eric's suggestions from: >> >> From: Eric Sunshine <sunshine@xxxxxxxxxxxxxx> >> Date: Sat, 18 Nov 2017 21:54:46 -0500 >> Message-ID: <CAPig+cSh0tVVkh0xF9FwCfM4gngAWMSN_FXd2zhzHcy2trYXfw@xxxxxxxxxxxxxx> > > Indeed. I'm squashing this into the patch: > > diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh > index f126177..d13d8c3 100755 > --- a/t/t9001-send-email.sh > +++ b/t/t9001-send-email.sh > @@ -173,8 +173,7 @@ test_expect_success $PREREQ 'cc trailer with various syntax' ' > ' > > test_expect_success $PREREQ 'setup fake get_maintainer.pl script for cc trailer' " > - cat >expected-cc-script.sh <<-EOF && > - #!/bin/sh > + write_script expected-cc-script.sh <<-EOF && > echo 'One Person <one@xxxxxxxxxxx> (supporter:THIS (FOO/bar))' > echo 'Two Person <two@xxxxxxxxxxx> (maintainer:THIS THING)' > echo 'Third List <three@xxxxxxxxxxx> (moderated list:THIS THING (FOO/bar))' Please do not forget to lose "chmod +x", which becomes unneeded when you use write_script. > @@ -186,7 +185,6 @@ test_expect_success $PREREQ 'setup fake get_maintainer.pl script for cc trailer' > " > > test_expect_success $PREREQ 'cc trailer with get_maintainer.pl output' ' > - test_commit cc-trailer-getmaint && > clean_fake_sendmail && > git send-email -1 --to=recipient@xxxxxxxxxxx \ > --cc-cmd="./expected-cc-script.sh" \
