Alex Bennée <alex.bennee@xxxxxxxxxx> writes: > Matthieu Moy <git@xxxxxxxxxxxxxxx> writes: > >> We now use Mail::Address unconditionaly, hence parse_mailboxes is now >> dead code. Remove it and its tests. >> >> Signed-off-by: Matthieu Moy <git@xxxxxxxxxxxxxxx> >> --- >> perl/Git.pm | 71 ---------------------------------------------------- >> t/t9000-addresses.sh | 27 -------------------- >> t/t9000/test.pl | 67 ------------------------------------------------- >> 3 files changed, 165 deletions(-) >> delete mode 100755 t/t9000-addresses.sh >> delete mode 100755 t/t9000/test.pl > > Should we add the tests for t9001-send-email.sh to guard against regressions? Tests in t9001 were only useful with our parse_mailboxes (they were just comparing parse_mailboxes and Mail::Address), so there's no point keeping them after we delete parse_mailboxes. Your added tests from https://public-inbox.org/git/20171116154814.23785-1-alex.bennee@xxxxxxxxxx would make sense OTOH. Not breaking Linux's flow is a nice thing to do ... Patch doing this follows (I'll resend the whole series with Eric's nit later). -- Matthieu Moy https://matthieu-moy.fr/
