On Tue, 19 Dec 2017, Junio C Hamano wrote:
> Alex Vandiver <alexmv@xxxxxxxxxxx> writes:
>
> > Subject: Re: [PATCH 2/6] fsmonitor: Add dir.h include, for untracked_cache_invalidate_path
>
> Perhaps
>
> "Subject: fsmonitor.h: include dir.h"
Certainly more concise.
> But I am not sure if this is a right direction to go in. If a .C
> user of fsmonitor needs (does not need) things from dir.h, that file
> can (does not need to) include dir.h itself.
Hm; I was patterning based on existing .h files, which don't seem shy
about pulling in other .h files.
> I think this header does excessive "static inline" as premature
> optimization, so a better "fix" to your perceived problem may be to
> make them not "static inline".
Yeah, quite possibly. Ben, do you recall your rationale for inlining
them in 6a6da08f6 ("fsmonitor: teach git to optionally utilize a file
system monitor to speed up detecting new or changed files.",
2017-09-22) ?
- Alex
