Alex Vandiver <alexmv@xxxxxxxxxxx> writes: > Subject: Re: [PATCH 2/6] fsmonitor: Add dir.h include, for untracked_cache_invalidate_path Perhaps "Subject: fsmonitor.h: include dir.h" But I am not sure if this is a right direction to go in. If a .C user of fsmonitor needs (does not need) things from dir.h, that file can (does not need to) include dir.h itself. I think this header does excessive "static inline" as premature optimization, so a better "fix" to your perceived problem may be to make them not "static inline". > This missing include is currently hidden by dint of the fact that > dir.h is already included by all things that currently include > fsmonitor.h > > Signed-off-by: Alex Vandiver <alexmv@xxxxxxxxxxx> > --- > fsmonitor.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fsmonitor.h b/fsmonitor.h > index cd3cc0ccf..5f68ca4d2 100644 > --- a/fsmonitor.h > +++ b/fsmonitor.h > @@ -1,5 +1,6 @@ > #ifndef FSMONITOR_H > #define FSMONITOR_H > +#include "dir.h" > > extern struct trace_key trace_fsmonitor;
