On 08/11/17 20:36, Stefan Beller wrote: > On Wed, Nov 8, 2017 at 12:28 PM, Ramsay Jones > <ramsay@xxxxxxxxxxxxxxxxxxxx> wrote: > >> t5300-pack-object.sh (Wstat: 256 Tests: 40 Failed: 2) > >> t5500-fetch-pack.sh (Wstat: 256 Tests: 355 Failed: 6) > > These are series > >> t5601-clone.sh (Wstat: 256 Tests: 102 Failed: 4) > > This one is a spurious test. I had that flake on me once in the last weeks, too. > But upon investigation I could not reproduce. > See https://public-inbox.org/git/xmqq376ipdpx.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxxx/ > No, this is not related to that. In fact several tests start working if I change the '--filter=blobs:limit=0' to instead read '--filter=blob:limit=0' (ie. change blob_s_ to blob). In fact t5601 now works with the following patch: -- >8 -- diff --git a/t/t5601-clone.sh b/t/t5601-clone.sh index f18d9454a..0074690f7 100755 --- a/t/t5601-clone.sh +++ b/t/t5601-clone.sh @@ -630,7 +630,7 @@ partial_clone () { test_config -C "$SERVER" uploadpack.allowfilter 1 && test_config -C "$SERVER" uploadpack.allowanysha1inwant 1 && - git clone --filter=blobs:limit=0 "$URL" client && + git clone --filter=blob:limit=0 "$URL" client && git -C client fsck && @@ -651,7 +651,7 @@ test_expect_success 'partial clone: warn if server does not support object filte test_create_repo server && test_commit -C server one && - git clone --filter=blobs:limit=0 "file://$(pwd)/server" client 2> err && + git clone --filter=blob:limit=0 "file://$(pwd)/server" client 2> err && test_i18ngrep "filtering not recognized by server" err ' @@ -673,7 +673,7 @@ test_expect_success 'batch missing blob request during checkout' ' test_config -C server uploadpack.allowfilter 1 && test_config -C server uploadpack.allowanysha1inwant 1 && - git clone --filter=blobs:limit=0 "file://$(pwd)/server" client && + git clone --filter=blob:limit=0 "file://$(pwd)/server" client && # Ensure that there is only one negotiation by checking that there is # only "done" line sent. ("done" marks the end of negotiation.) @@ -705,7 +705,7 @@ test_expect_success 'batch missing blob request does not inadvertently try to fe test_config -C server uploadpack.allowanysha1inwant 1 && # Make sure that it succeeds - git clone --filter=blobs:limit=0 "file://$(pwd)/server" client + git clone --filter=blob:limit=0 "file://$(pwd)/server" client ' . "$TEST_DIRECTORY"/lib-httpd.sh -- 8< -- A similar patch to 't/t5300-pack-object.sh' gets one of the two failing tests working. I haven't looked at 't/t5500-fetch-pack.sh' yet. ATB, Ramsay Jones
