On Wed, Nov 1, 2017 at 5:37 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > On Wed, Nov 1, 2017 at 9:26 PM, Johannes Schindelin > <Johannes.Schindelin@xxxxxx> wrote: >> >> ... >> ( >> for x in four three >> do >> git rm $x && >> git commit -m "remote $x" || >> exit >> done >> ) && >> test 0 -eq $? && >> ... >> >> Ugly? Yes. Correct? Also yes. > > I think returning non-zero with "return" is how other tests avoid an > extra level of subshell. > Ugly? Yes. Correct? Questionable but it seems to work for those who > wrote them ;-) I think I'll go without the extra subshell and with s/return 1/false/ as the exact value doesn't matter. Thanks for hinting at correct implementations