Jonathan Nieder <jrnieder@xxxxxxxxx> writes: > Jonathan Tan wrote: >>> On 10/23, Jonathan Nieder wrote: > >>>> If this looks good, I can reroll in a moment. >> >> Yes, this looks good. > > Thanks. Here goes. > > The interdiff is upthread. Thanks, all, for the quick review. > > Jonathan Nieder (5): > connect: split git:// setup into a separate function > connect: split ssh command line options into separate function > ssh: 'auto' variant to select between 'ssh' and 'simple' > ssh: 'simple' variant does not support -4/-6 > ssh: 'simple' variant does not support --port These looked mostly good. I left some nitpicks on individual patches.