Hi, Brandon Williams wrote: > On 10/03, Jonathan Nieder wrote: >> What happens if I specify a ssh://host:port/path URL and the SSH >> implementation is of 'simple' type? > > The port would only be sent if your ssh command supported it. Thanks again for this patch. William Yan (cc-ed) ran into this case, and based on his experience here are some patches to handle it. See patches 3 and 5 for more details. Longer term, I hope that wrapper script authors start setting GIT_SSH_VARIANT based on the behavior they want (e.g. like (*)) instead of making us autodetect, but this should be useful as a stopgap in the meantime. These patches are against bw/protocol-v1, which is in "next". Thoughts of all kinds welcome, as always. Sincerely, Jonathan Nieder (5): connect: split git:// setup into a separate function connect: split ssh command line options into separate function ssh: 'auto' variant to select between 'ssh' and 'simple' ssh: 'simple' variant does not support -4/-6 ssh: 'simple' variant does not support --port Documentation/config.txt | 17 +-- connect.c | 275 ++++++++++++++++++++++++++++++----------------- t/t5601-clone.sh | 34 ++++-- t/t5603-clone-dirname.sh | 2 + 4 files changed, 214 insertions(+), 114 deletions(-)
