Re: [PATCH v2 1/9] perf/run: add '--config' option to the 'run' script

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 18, 2017 at 12:58 PM, Kevin Daudt <me@xxxxxxxxx> wrote:
> On Sat, Sep 23, 2017 at 07:55:56PM +0000, Christian Couder wrote:

>> diff --git a/t/perf/run b/t/perf/run
>> index beb4acc0e428d..1e7c2a59e45dc 100755
>> --- a/t/perf/run
>> +++ b/t/perf/run
>> @@ -2,9 +2,14 @@
>>
>>  case "$1" in
>>       --help)
>> -             echo "usage: $0 [other_git_tree...] [--] [test_scripts]"
>> +             echo "usage: $0 [--config file] [other_git_tree...] [--] [test_scripts]"
>>               exit 0
>>               ;;
>> +     --config)
>> +             shift
>> +             GIT_PERF_CONFIG_FILE=$(cd "$(dirname "$1")"; pwd)/$(basename "$1")
>
> Is the idea of this construct to do some kind of normalization?
> Otherwise it seems to just result in $1 again.

Yeah, the idea is to get a full path when you are given a relative path.



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux