On Sat, Sep 23, 2017 at 07:55:56PM +0000, Christian Couder wrote:
> It is error prone and tiring to use many long environment
> variables to give parameters to the 'run' script.
>
> Let's make it easy to store some parameters in a config
> file and to pass them to the run script.
>
> The GIT_PERF_CONFIG_FILE variable will be set to the
> argument of the '--config' option. This variable is not
> used yet. It will be used in a following commit.
>
> Signed-off-by: Christian Couder <chriscool@xxxxxxxxxxxxx>
> ---
> t/perf/run | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/t/perf/run b/t/perf/run
> index beb4acc0e428d..1e7c2a59e45dc 100755
> --- a/t/perf/run
> +++ b/t/perf/run
> @@ -2,9 +2,14 @@
>
> case "$1" in
> --help)
> - echo "usage: $0 [other_git_tree...] [--] [test_scripts]"
> + echo "usage: $0 [--config file] [other_git_tree...] [--] [test_scripts]"
> exit 0
> ;;
> + --config)
> + shift
> + GIT_PERF_CONFIG_FILE=$(cd "$(dirname "$1")"; pwd)/$(basename "$1")
Is the idea of this construct to do some kind of normalization?
Otherwise it seems to just result in $1 again.
> + export GIT_PERF_CONFIG_FILE
> + shift ;;
> esac
>
> die () {
>
> --
> https://github.com/git/git/pull/408
